You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/10 10:23:39 UTC

[GitHub] [spark] ScrapCodes commented on a change in pull request #27858: [SPARK-31062][K8S][TESTS] Improve spark decommissioning k8s test reliability

ScrapCodes commented on a change in pull request #27858: [SPARK-31062][K8S][TESTS] Improve spark decommissioning k8s test reliability
URL: https://github.com/apache/spark/pull/27858#discussion_r390217184
 
 

 ##########
 File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DecommissionSuite.scala
 ##########
 @@ -32,8 +32,9 @@ private[spark] trait DecommissionSuite { k8sSuite: KubernetesSuite =>
     runSparkApplicationAndVerifyCompletion(
       appResource = PYSPARK_DECOMISSIONING,
       mainClass = "",
-      expectedLogOnCompletion = Seq("decommissioning executor",
-        "Finished waiting, stopping Spark"),
+      expectedLogOnCompletion = Seq(
+        "Finished waiting, stopping Spark",
+        "decommissioning executor"),
 
 Review comment:
   Hi Holden, in one of the failed runs on Jenkins, I have found this text did not appear at all in the Logs. In order to fix the flakiness, the cause might be deeper than the order in which they appear. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org