You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by escabe <gi...@git.apache.org> on 2014/12/17 11:52:20 UTC
[GitHub] cxf pull request: Fix for [CXF-6161]
GitHub user escabe opened a pull request:
https://github.com/apache/cxf/pull/43
Fix for [CXF-6161]
Instead of using a local filename based on the original URL of an
wsdl:import use a numbered name: importNN.wsdl. Similar to schema
imports. This should resolve issue [CXF-6161] in which an invalid
filename may be generated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/escabe/cxf 2.7.x-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit a9c9baea404cb79ff7555ae325bc46d74544eb1c
Author: Martijn Aben <ma...@mathworks.nl>
Date: 2014-12-17T10:48:29Z
Fix for [CXF-6161]
Instead of using a local filename based on the original URL of an
wsdl:import use a numbered name: importNN.wsdl. Similar to schema
imports. This should resolve issue [CXF-6161] in which an invalid
filename may be generated.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Fix for [CXF-6161]
Posted by tomitribe-dev <gi...@git.apache.org>.
Github user tomitribe-dev commented on the pull request:
https://github.com/apache/cxf/pull/43#issuecomment-218430629
Build triggered. sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #43: Fix for [CXF-6161]
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Fix for [CXF-6161]
Posted by escabe <gi...@git.apache.org>.
Github user escabe commented on the pull request:
https://github.com/apache/cxf/pull/43#issuecomment-67949395
Ok, I could look into that. Before I do so however, do you have a preferred
way of checking for valid file names in this project? Is doing a
File.createNewFile() inside TRY-CATCH acceptable?
On Thu, Dec 18, 2014 at 12:00 AM, Daniel Kulp <no...@github.com>
wrote:
> If the file is a valid name, I would greatly prefer to keep the name.
>
> Also, one of the tests fails due to this. testClientJar fails due to:
>
> assertTrue("hello_world_messages.wsdl is expected",
> jarEntries.contains("hello_world_messages.wsdl"));
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cxf/pull/43#issuecomment-67413089>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Fix for [CXF-6161]
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the pull request:
https://github.com/apache/cxf/pull/43#issuecomment-67413089
If the file is a valid name, I would greatly prefer to keep the name.
Also, one of the tests fails due to this. testClientJar fails due to:
assertTrue("hello_world_messages.wsdl is expected",
jarEntries.contains("hello_world_messages.wsdl"));
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: Fix for [CXF-6161]
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the pull request:
https://github.com/apache/cxf/pull/43#issuecomment-67958475
I just added a utility method in FileUtils.isValidFileName() which should work. Feel free to fix that if it's not complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---