You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/05 13:48:00 UTC

[GitHub] [iotdb] SzyWilliam opened a new pull request, #8339: [IOTDB-5123] fix ratis disk control param mismatch

SzyWilliam opened a new pull request, #8339:
URL: https://github.com/apache/iotdb/pull/8339

   See https://issues.apache.org/jira/browse/IOTDB-5123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8339: [IOTDB-5123] fix ratis disk control param mismatch

Posted by GitBox <gi...@apache.org>.

OneSizeFitsQuorum commented on code in PR #8339:
URL: https://github.com/apache/iotdb/pull/8339#discussion_r1040363710


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ConsensusManager.java:
##########
@@ -166,7 +166,7 @@ private void setConsensusLayer(ConfigNodeRegionStateMachine stateMachine) throws
                                       .setClientRetryMaxSleepTimeMs(
                                           CONF.getConfigNodeRatisMaxSleepTimeMs())
                                       .setTriggerSnapshotFileSize(
-                                          CONF.getConfigNodeRatisLogMaxMB() * 1024 * 1024)

Review Comment:
   * 1024 * 1024？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8339: [IOTDB-5123] fix ratis disk control param mismatch

Posted by GitBox <gi...@apache.org>.

OneSizeFitsQuorum merged PR #8339:
URL: https://github.com/apache/iotdb/pull/8339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org