You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2023/01/01 14:20:00 UTC

[jira] [Commented] (MNG-7222) Validate and warn for naming collisions between Maven and System properties

    [ https://issues.apache.org/jira/browse/MNG-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653415#comment-17653415 ] 

Konrad Windszus commented on MNG-7222:
--------------------------------------

I don't think we should touch the order of precedence but just clarify the documentation at https://maven.apache.org/pom.html#properties.
This means, model properties overwrite system properties and user properties overwrite system properties. 

> Validate and warn for naming collisions between Maven and System properties
> ---------------------------------------------------------------------------
>
>                 Key: MNG-7222
>                 URL: https://issues.apache.org/jira/browse/MNG-7222
>             Project: Maven
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: waiting-for-feedback
>
>
> As properties referenced via {{${x}}} are first being resolved against system properties and only afterwards against Maven properties according to https://maven.apache.org/pom.html#properties. As this is often not noticed  such collisions should be detected by Maven and lead to a WARN.
> An example for such a collision can be seen at https://github.com/adobe/aem-core-wcm-components/blob/6a294b0483c711a0283474f962a4643234e47c6e/parent/pom.xml#L64 which is never effective as this is always overridden by https://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html
> At least the mandatory properties (available on all JREs) outlined at https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#getProperties-- should always lead to a WARN.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)