You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 23:49:15 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #11996: ARROW-15114: [C++] GcsFileSystem uses metadata for directory markers

emkornfield commented on a change in pull request #11996:
URL: https://github.com/apache/arrow/pull/11996#discussion_r779940287



##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -505,20 +555,23 @@ class GcsFileSystem::Impl {
   }
 
  private:
-  static Result<FileInfo> GetFileInfoDirectory(const GcsPath& path,
-                                               const google::cloud::Status& status) {
-    using ::google::cloud::StatusCode;
-    auto canonical = internal::EnsureTrailingSlash(path.full_path);
+  static bool IsDirectory(gcs::ObjectMetadata const& o) {

Review comment:
       ```suggestion
     static bool IsDirectory(const gcs::ObjectMetadata& o) {
   ```
   nit




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org