You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Jarek Potiuk (Jira)" <ji...@apache.org> on 2019/12/17 22:36:00 UTC

[jira] [Updated] (AIRFLOW-5309) Use assert_called_once or has_calls in tests

     [ https://issues.apache.org/jira/browse/AIRFLOW-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Potiuk updated AIRFLOW-5309:
----------------------------------
    Fix Version/s: 2.0.0

> Use assert_called_once or has_calls in tests
> --------------------------------------------
>
>                 Key: AIRFLOW-5309
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5309
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 1.10.4
>            Reporter: Tomasz Urbaszek
>            Assignee: Tomasz Urbaszek
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Using mock.assert_call_with method can result in flaky tests (ex. iterating through dict in python 3.5 which does not store order of elements). That's why it's better to use assert_called_once_with or has_calls methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)