You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/28 04:36:16 UTC

[GitHub] [pulsar] yjshen opened a new pull request #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

yjshen opened a new pull request #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436
 
 
   Fixes #6417. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436#issuecomment-592309610
 
 
   cc @sijie @codelipenghui for review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436#issuecomment-598573502
 
 
   cherry-picked into branch-2.5

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui merged pull request #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436#issuecomment-593062708
 
 
   @xiemeilong the cached client is shared among all threads in the same task manager. All consumers or producers with the same connection configuration to pulsar inside the task manager would share one same client instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436#issuecomment-592310020
 
 
   BTW, I cannot choose reviewers for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436#issuecomment-592322918
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] xiemeilong commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance

Posted by GitBox <gi...@apache.org>.
xiemeilong commented on issue #6436: [Flink-Connector]Get PulsarClient from cache should always return an open instance
URL: https://github.com/apache/pulsar/pull/6436#issuecomment-592923099
 
 
   The client will closed  on everytime  restarting occur,may should not just  add a condition on the state. The cache seems will not be hited .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services