You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tibo (JIRA)" <ji...@apache.org> on 2017/09/28 02:24:01 UTC

[jira] [Updated] (MCHECKSTYLE-341) Introduce an expectedViolation flag

     [ https://issues.apache.org/jira/browse/MCHECKSTYLE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tibo updated MCHECKSTYLE-341:
-----------------------------
    Description: 
We are trying to fix our tech debt step by step using the maxAllowedViolation flag and reducing the number slowly.
We have 400+ maven module in our project and developer never update this flag, So basically when someone is fixing checkstyle error without updating the flag, it leaves room for another developer to introduce new errors...

I would like an expectedViolation flag just to force people who are fixing issues to also update the count...

I believe the maxAllowedViolation should have been an expectedViolation from the start. I don't believe anyone wants to leave room for violation, you just want, for an existing project, to explicitly specify the current number of violation and disallow through pull request the number to go up.

  was:
We are trying to fix our tech debt step by step using the maxViolation flag and reducing the number slowly.
We have 400+ maven module in our project and developer never update this flag, So basically when someone is fixing checkstyle error without updating the flag, it leaves room for another developer to introduce new errors...

I would like an expectedViolation flag just to force people who are fixing issues to also update the count...


> Introduce an expectedViolation flag
> -----------------------------------
>
>                 Key: MCHECKSTYLE-341
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-341
>             Project: Maven Checkstyle Plugin
>          Issue Type: New Feature
>          Components: checkstyle:check
>    Affects Versions: 2.17
>            Reporter: Tibo
>            Priority: Minor
>
> We are trying to fix our tech debt step by step using the maxAllowedViolation flag and reducing the number slowly.
> We have 400+ maven module in our project and developer never update this flag, So basically when someone is fixing checkstyle error without updating the flag, it leaves room for another developer to introduce new errors...
> I would like an expectedViolation flag just to force people who are fixing issues to also update the count...
> I believe the maxAllowedViolation should have been an expectedViolation from the start. I don't believe anyone wants to leave room for violation, you just want, for an existing project, to explicitly specify the current number of violation and disallow through pull request the number to go up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)