You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/07/10 21:24:09 UTC

Re: Review Request 60520: Remove posix/subprocess.hpp dependencies.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60520/#review180099
-----------------------------------------------------------




src/checks/checker_process.cpp
Lines 126-136 (patched)
<https://reviews.apache.org/r/60520/#comment255122>

    '3rdparty/libprocess/include/subprocess.hpp' exposes several platform-specific objects; is there a reason we shouldn't do the same with this Linux-specific `defaultClone`?


- Greg Mann


On June 28, 2017, 10:49 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60520/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 10:49 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix a number of places where we were depending on symbols made
> visible by <process/posix/subprocess.hpp>. In most cases, this is
> just tweaking the includes, but in the Checker we just duplicate
> the trivial fork(2) helper since that is easer than trying to
> export it as a libprocess API.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp 66f5452bb5f9c7f45819c221be7b098e5999b7a7 
>   src/slave/containerizer/mesos/isolators/volume/image.cpp c89af3e0a16f769c45f2846d1e76baedb8248d4d 
>   src/uri/fetchers/docker.cpp 7f3e4e73d1dc5d15f875e2890acbe5369fb59d78 
> 
> 
> Diff: https://reviews.apache.org/r/60520/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26).
> 
> 
> Thanks,
> 
> James Peach
> 
>