You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucy.apache.org by "Marvin Humphrey (Created) (JIRA)" <ji...@apache.org> on 2011/11/04 02:51:32 UTC

[lucy-issues] [jira] [Created] (LUCY-186) Terminate connection from SearchClient properly

Terminate connection from SearchClient properly
-----------------------------------------------

                 Key: LUCY-186
                 URL: https://issues.apache.org/jira/browse/LUCY-186
             Project: Lucy
          Issue Type: Bug
          Components: Search
    Affects Versions: 0.2.1 (incubating), 0.2.0 (incubating), 0.1.0 (incubating)
            Reporter: Marvin Humphrey
            Assignee: Marvin Humphrey
             Fix For: 0.3.0 (incubating)


SearchClient is currently leaving open its connections to SearchServer,
causing SearchServer to crash when the first SearchClient goes away 
and a new one tries to connect.  To mitigate this problem, we should
have SearchClient's destructor invoke close().

Bug hunted by Goran Kent on the user list: http://s.apache.org/bBf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[lucy-issues] [jira] [Resolved] (LUCY-186) Terminate connection from SearchClient properly

Posted by "Marvin Humphrey (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCY-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marvin Humphrey resolved LUCY-186.
----------------------------------

    Resolution: Fixed
    
> Terminate connection from SearchClient properly
> -----------------------------------------------
>
>                 Key: LUCY-186
>                 URL: https://issues.apache.org/jira/browse/LUCY-186
>             Project: Lucy
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 0.1.0 (incubating), 0.2.0 (incubating), 0.2.1 (incubating)
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.3.0 (incubating)
>
>         Attachments: LUCY-186.patch
>
>
> SearchClient is currently leaving open its connections to SearchServer,
> causing SearchServer to crash when the first SearchClient goes away 
> and a new one tries to connect.  To mitigate this problem, we should
> have SearchClient's destructor invoke close().
> Bug hunted by Goran Kent on the user list: http://s.apache.org/bBf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[lucy-issues] [jira] [Updated] (LUCY-186) Terminate connection from SearchClient properly

Posted by "Marvin Humphrey (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCY-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marvin Humphrey updated LUCY-186:
---------------------------------

    Attachment: LUCY-186.patch

This patch invokes close() from within DESTROY(), and removes it from the
vestigial NUKE(), which was an alternate destructor under an experimental
object model from several years ago, long since discarded.

Note that invoking close() from within DESTROY() is not entirely satisfactory,
as a SearchClient which is displaced without being destroyed will continue to
trigger bad behavior.  To solve this problem more robustly, we need to raise
the profile of close() and encourage userland code to use it.  This will be
even more important when we nest Lucy within a GC'd language like Ruby and can
no longer count on deterministic destructor behavior.

                
> Terminate connection from SearchClient properly
> -----------------------------------------------
>
>                 Key: LUCY-186
>                 URL: https://issues.apache.org/jira/browse/LUCY-186
>             Project: Lucy
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 0.1.0 (incubating), 0.2.0 (incubating), 0.2.1 (incubating)
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.3.0 (incubating)
>
>         Attachments: LUCY-186.patch
>
>
> SearchClient is currently leaving open its connections to SearchServer,
> causing SearchServer to crash when the first SearchClient goes away 
> and a new one tries to connect.  To mitigate this problem, we should
> have SearchClient's destructor invoke close().
> Bug hunted by Goran Kent on the user list: http://s.apache.org/bBf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira