You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "sanskar-thakur (via GitHub)" <gi...@apache.org> on 2023/02/16 17:12:28 UTC
[GitHub] [incubator-eventmesh] sanskar-thakur opened a new pull request, #3175: [ISSUE #3088] Argument 'msg.getSubject()' might be null
sanskar-thakur opened a new pull request, #3175:
URL: https://github.com/apache/incubator-eventmesh/pull/3175
Fixes #3088 .
### Modifications
Added check to avoid NPE.
### Documentation
- Does this pull request introduce a new feature? **(no)**
- If yes, how is the feature documented? **(not applicable)**
- If a feature is not applicable for documentation, explain why? **(bug fix)**
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation **(not applicable)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3175: [ISSUE #3088] Argument 'msg.getSubject()' might be null
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3175:
URL: https://github.com/apache/incubator-eventmesh/pull/3175#issuecomment-1435935641
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3175](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56ffb79) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/959d2b0a0b40a9f868ba10f2ebaac9960e4db1b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (959d2b0) will **decrease** coverage by `0.02%`.
> The diff coverage is `12.89%`.
> :exclamation: Current head 56ffb79 differs from pull request most recent head 295145b. Consider uploading reports for the commit 295145b to get more accurate results
```diff
@@ Coverage Diff @@
## master #3175 +/- ##
============================================
- Coverage 13.05% 13.04% -0.02%
- Complexity 1145 1158 +13
============================================
Files 548 548
Lines 28747 28746 -1
Branches 2857 2843 -14
============================================
- Hits 3754 3750 -4
- Misses 24670 24674 +4
+ Partials 323 322 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...entmesh/common/protocol/http/HttpEventWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL0h0dHBFdmVudFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/eventmesh/common/utils/JsonUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9Kc29uVXRpbHMuamF2YQ==) | `34.21% <ø> (ø)` | |
| [...va/org/apache/eventmesh/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9OZXRVdGlscy5qYXZh) | `74.28% <ø> (ø)` | |
| [...entmesh/connector/kafka/consumer/ConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9rYWZrYS9jb25zdW1lci9Db25zdW1lckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../connector/kafka/consumer/KafkaConsumerRunner.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9rYWZrYS9jb25zdW1lci9LYWZrYUNvbnN1bWVyUnVubmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...entmesh/connector/kafka/producer/ProducerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9rYWZrYS9wcm9kdWNlci9Qcm9kdWNlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...sh/connector/knative/consumer/DefaultConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1rbmF0aXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2tuYXRpdmUvY29uc3VtZXIvRGVmYXVsdENvbnN1bWVyLmphdmE=) | `56.25% <0.00%> (-2.58%)` | :arrow_down: |
| [.../connector/rocketmq/consumer/PushConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yb2NrZXRtcS9jb25zdW1lci9QdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `24.47% <0.00%> (ø)` | |
| [...nector/rocketmq/consumer/RocketMQConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yb2NrZXRtcS9jb25zdW1lci9Sb2NrZXRNUUNvbnN1bWVySW1wbC5qYXZh) | `8.82% <ø> (-2.61%)` | :arrow_down: |
| [...mesh/connector/rocketmq/producer/ProducerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yb2NrZXRtcS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yb2NrZXRtcS9wcm9kdWNlci9Qcm9kdWNlckltcGwuamF2YQ==) | `21.64% <0.00%> (ø)` | |
| ... and [144 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/3175?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx merged pull request #3175: [ISSUE #3088] Argument 'msg.getSubject()' might be null
Posted by "jonyangx (via GitHub)" <gi...@apache.org>.
jonyangx merged PR #3175:
URL: https://github.com/apache/incubator-eventmesh/pull/3175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org