[GitHub] [nifi-minifi-cpp] msharee9 edited a comment on issue #674: Minificpp 1007 - ECU C2 integration.

[GitBox <gi...@apache.org>]

msharee9 edited a comment on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-561880970
 
 
   > Besides the comments added my main concern is that I still don't feel convinced about the need of implementing thread pools, message queues, ringbuffers and all the related stuff.
   
   The main reason for having thread pool is to let the user automatically start input and output processing when commanded by the c2 agent.
   Also, it makes using the ecu api very simple. Create ecu, set properties, start forwarding.
   If you look at ecuapi.h, an ecu can be started as follows,
   ecu = create_ecu("myecu", TAILFILE, SITE2SITE);
   set_input_property(ecu, ...);
   set_output_property(ecu, ...);
   start_ecu_context(ecu);
   
   After the ecu is started the application using the sdk won't block and the data ingestion and forwarding is started in the background in the threadpool.
   
   Ofcourse, the api is not limited to this, the user can opt to call out the functions individually to manually ingest data (some work might be needed here) and forward it if he wishes.
   
   The message queue is implemented to concurrently run the input and output processors and the ring buffer to limit the size of buffering. The size of the buffer can be configurable (some work is needed for making it configurable) though.
   
   One of the other goals of this sdk is to let the user integrate ecu into his application. We want to make it easier for the user to do that by making the api calls to a few number.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services