[GitHub] holdenk commented on a change in pull request #4315: [AIRFLOW-1381] Specify host temporary directory

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #4315: [AIRFLOW-1381] Specify host temporary directory
URL: https://github.com/apache/incubator-airflow/pull/4315#discussion_r245078479
 
 

 ##########
 File path: tests/operators/test_docker_operator.py
 ##########
 @@ -57,6 +57,7 @@ def test_execute(self, client_class_mock, mkdtemp_mock):
 
         operator = DockerOperator(api_version='1.19', command='env', environment={'UNIT': 'TEST'},
                                   image='ubuntu:latest', network_mode='bridge', owner='unittest',
+                                  host_tmp_dir='/host/airflow',
 
 Review comment:
   This is optional, but given that we've overridden the host temporary directory, it might make sense to change the mock on L46 to return something under /host/airflow and update the volume asserts on L79

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services