You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by trengrj <gi...@git.apache.org> on 2016/10/31 11:50:27 UTC

[GitHub] zeppelin pull request #1572: [ZEPPELIN-1593] Enforce sorting on dynamic form...

GitHub user trengrj opened a pull request:

    https://github.com/apache/zeppelin/pull/1572

    [ZEPPELIN-1593] Enforce sorting on dynamic form elements

    ### What is this PR for?
    Current dynamic forms elements in zeppelin-web have no ordering. The ordering of the dynamic elements is random which can be annoying when you have many of them.
    
    The root cause is that the angular frontend uses "for key in object" pattern with no sorting. I have added sorting.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    [ZEPPELIN-1593](https://issues.apache.org/jira/browse/ZEPPELIN-1593)
    
    ### How should this be tested?
    Dynamic forms should now have fields sorted by name.
    ```
    %md
    ${a=1}
    ${b=1}
    ${c=1}
    ${d=1}
    ${bb=1}
    ${ba=1}
    ```
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trengrj/zeppelin sort-form

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1572
    
----
commit 7ba9a3ba23b4a744d957474f2c4e922dc885f597
Author: John Trengrove <jo...@servian.com.au>
Date:   2016-10-31T11:40:43Z

    [ZEPPELIN-1593] Enforce sorting on dynamic form elements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1572: [ZEPPELIN-1593] Enforce sorting on dynamic form elemen...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1572
  
    Thanks @trengrj for the contribution. 
    Looks good to me.
    
    CI failure are irrelevant to this change.
    Merge to master if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1572: [ZEPPELIN-1593] Enforce sorting on dynamic form...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1572


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---