You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2024/01/10 09:03:51 UTC
[PR] [FLINK-34047][ci] Make CI scripts agnostic to CI environment [flink]
XComp opened a new pull request, #24061:
URL: https://github.com/apache/flink/pull/24061
## What is the purpose of the change
Azure Pipelines (see [pre-defined env variables](https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml)) and GitHub (see [pre-defined env variables](https://docs.github.com/en/actions/learn-github-actions/variables)) use a different set of environment variables. The CI tools rely on some of the environment variables that are provided by Azure Pipelines. With the migration to GitHub Actions we need to make the scripts CI environment agnostic.
## Brief change log
* Made `tools/azure-pipelines/debug_files_utils.sh` use parameters instead of relying on environment variables
* Made `tools/azure-pipelines/uploading_watchdog.sh` consider Azure Pipelines and GitHub Actions environments
* I checked for occurrences of the following substrings (based on [Azure Pipelines pre-defined env variables](https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml)) in the code to verify that we're not missing any other env variables:
* `$AGENT_`
* `$SYSTEM_`
* `$BUILD_`
* `$COMMON_`
* `$ENV_`
* `$CHECKS`
## Verifying this change
* PR CI should still work w/o errors
* The [follow-up FLINK-33914 PR](https://github.com/apache/flink/pull/23970) should fail without the right environment variables being set in the fork XComp/flink's project being set
* We should see a successful build with the necessary environment variables being set for FLINK-33914
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? in-code documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34047][ci] Make CI scripts agnostic to CI environment [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #24061:
URL: https://github.com/apache/flink/pull/24061#issuecomment-1884943688
> (Could also move the debug_files_utils script out of the azure-pipelines directory but 🙈 )
I rather leave everything in one place for now and move it to a better place when removing Azure Pipelines :innocent:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34047][ci] Make CI scripts agnostic to CI environment [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #24061:
URL: https://github.com/apache/flink/pull/24061#issuecomment-1884840582
(Could also move the scripts out of the azure-pipelines directory but 🙈 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34047][ci] Make CI scripts agnostic to CI environment [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24061:
URL: https://github.com/apache/flink/pull/24061#issuecomment-1884456589
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91a76e9e6c70e62f8b0ca9e0544a83c113b40ca5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "91a76e9e6c70e62f8b0ca9e0544a83c113b40ca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91a76e9e6c70e62f8b0ca9e0544a83c113b40ca5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34047][ci] Make CI scripts agnostic to CI environment [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #24061:
URL: https://github.com/apache/flink/pull/24061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org