You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/04 12:06:08 UTC
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich opened a new pull request, #5: Update Scala versions and add Scala 2.12 to CI
mdedetrich opened a new pull request, #5:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/5
This PR does the following
- Updates Scala 2.11 and 2.12 to the latest versions
- Replaces `setup-scala` with `setup-java`
- Adds support for Scala 2.11/2.12 to the CI by adding a matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #5: Update Scala versions and add Scala 2.12 to CI
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #5:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/5#discussion_r1157175198
##########
core/src/main/scala/akka/persistence/r2dbc/ConnectionFactoryProvider.scala:
##########
@@ -9,14 +9,14 @@ import java.util.concurrent.ConcurrentHashMap
import scala.concurrent.Future
import scala.concurrent.duration.Duration
-import scala.jdk.CollectionConverters.ConcurrentMapHasAsScala
import akka.Done
import akka.actor.CoordinatedShutdown
import akka.actor.typed.ActorSystem
import akka.actor.typed.Extension
import akka.actor.typed.ExtensionId
import akka.persistence.r2dbc.internal.R2dbcExecutor
+import akka.util.ccompat.JavaConverters._
Review Comment:
This change is necessary since we are now cross compiling for Scala 2.12 and well as 2.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich merged pull request #5: Update Scala versions and add Scala 2.12 to CI
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #5:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org