You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/29 17:30:29 UTC
[GitHub] [kafka] abbccdda opened a new pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
abbccdda opened a new pull request #8952:
URL: https://github.com/apache/kafka/pull/8952
We are missing a `toString` logic in the RocksDbWindowBytesStoreSupplier, such that the error log wasn't able to print out the supplier's actual config:
```
Exception in thread "main" org.apache.kafka.streams.errors.StreamsException: Window settings mismatch. WindowBytesStoreSupplier settings org.apache.kafka.streams.state.internals.RocksDbWindowBytesStoreSupplier@61f8bee4 must match JoinWindows settings JoinWindows{beforeMs=500, afterMs=500, graceMs=-1, maintainDurationMs=86400000, segments=3}
at org.apache.kafka.streams.kstream.internals.KStreamImplJoin.assertWindowSettings(KStreamImplJoin.java:173)
at org.apache.kafka.streams.kstream.internals.KStreamImplJoin.join(KStreamImplJoin.java:96)
at org.apache.kafka.streams.kstream.internals.KStreamImpl.doJoin(KStreamImpl.java:969)
at org.apache.kafka.streams.kstream.internals.KStreamImpl.join(KStreamImpl.java:858)
at io.confluent.streams.bench.table.App.getStreamStreamJoinTopology(App.java:1231)
at io.confluent.streams.bench.table.App.main(App.java:609)
```
This PR amends this gap by providing an implementation for RocksDbWindowBytesStoreSupplier `toString`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8952:
URL: https://github.com/apache/kafka/pull/8952#issuecomment-651258911
@ableegoldman @cadonna @vvcephei Call for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda merged pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #8952:
URL: https://github.com/apache/kafka/pull/8952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8952:
URL: https://github.com/apache/kafka/pull/8952#issuecomment-651419611
Guess that answers the question of whether EosBetaupgradeIntegrationTest is still flaky cc @guozhangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8952:
URL: https://github.com/apache/kafka/pull/8952#issuecomment-651391283
@ableegoldman There is already one in the `InMemoryWindowBytesStoreSupplier`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8952:
URL: https://github.com/apache/kafka/pull/8952#issuecomment-651418736
Have done two runs of tests while only flaky tests are failing:
```
kafka.admin.TopicCommandWithAdminClientTest.testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
```
Will go ahead and merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda commented on pull request #8952: MINOR: Add toString for RocksDbWindowBytesStoreSupplier
Posted by GitBox <gi...@apache.org>.
abbccdda commented on pull request #8952:
URL: https://github.com/apache/kafka/pull/8952#issuecomment-651357330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org