You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/04/30 22:41:49 UTC
[PR] chore: Implement remaining CAST tests [datafusion-comet]
andygrove opened a new pull request, #356:
URL: https://github.com/apache/datafusion-comet/pull/356
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/datafusion-comet/issues/286
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Implement more tests.
## Status:
- Tests: 104
- Passing: 44
- Ignored: 60
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Implement tests for casting from Date and TimestampType
- Change some tests from `ignore` to `test`
- Update comments in failing tests
- Note that TIMESTAMP_NTZ is not tested yet because that requires some shim work, so will tackle that in a separate PR
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Implement remaining CAST tests [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #356:
URL: https://github.com/apache/datafusion-comet/pull/356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Implement remaining CAST tests [datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #356:
URL: https://github.com/apache/datafusion-comet/pull/356#discussion_r1585757000
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -87,13 +87,11 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
// CAST from BooleanType
- ignore("cast BooleanType to ByteType") {
- // https://github.com/apache/datafusion-comet/issues/311
+ test("cast BooleanType to ByteType") {
castTest(generateBools(), DataTypes.ByteType)
}
Review Comment:
This is not supported before and supported now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Implement remaining CAST tests [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #356:
URL: https://github.com/apache/datafusion-comet/pull/356#discussion_r1585773194
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -87,13 +87,11 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
// CAST from BooleanType
- ignore("cast BooleanType to ByteType") {
- // https://github.com/apache/datafusion-comet/issues/311
+ test("cast BooleanType to ByteType") {
castTest(generateBools(), DataTypes.ByteType)
}
Review Comment:
Not quite. It was disabled before and now it is enabled. With this PR, I enabled all of the tests and then kept the ones that are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Implement remaining CAST tests [datafusion-comet]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #356:
URL: https://github.com/apache/datafusion-comet/pull/356#discussion_r1585774388
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -87,13 +87,11 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
// CAST from BooleanType
- ignore("cast BooleanType to ByteType") {
- // https://github.com/apache/datafusion-comet/issues/311
+ test("cast BooleanType to ByteType") {
castTest(generateBools(), DataTypes.ByteType)
}
Review Comment:
Got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org