[GitHub] jmeter pull request #437: Native properties

[FSchumacher <gi...@git.apache.org>]

GitHub user FSchumacher opened a pull request:

    https://github.com/apache/jmeter/pull/437

    Native properties

    ## Description
    Use native encoding for properties files in the source directories
    
    ## Motivation and Context
    Currently the properties files are encoded using the native2ascii program as properties file read by java have to be in ASCII. Those encoded files are hard to read and error prone. By converting them to UTF-8 it should be easier to maintain.
    The properties files will be encoded when the corresponding sources are compiled. 
    
    ## How Has This Been Tested?
    Checked the generated properties file by hand and run JMeter in GUI mode.
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - New feature (non-breaking change which adds functionality)
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
    - [x] My code follows the [code style][style-guide] of this project.
    - [ ] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FSchumacher/jmeter native-properties

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #437
    
----
commit e3efb950bde2f31270023833cf6dc87973a4b698
Author: Felix Schumacher <fe...@...>
Date:   2019-01-11T17:38:51Z

    Use native2ascii while compiling the sources.

commit 53571eedd60ad2e3080ee666b7e41cc6fc71c488
Author: Felix Schumacher <fe...@...>
Date:   2019-01-11T17:41:44Z

    Converted properties to utf8
    
    Used the tool native2ascii to convert the ascii encoded properties
    to utf-8. It should now be easier for language translators to edit those
    files.
    
    $ find src/ -name "*.properties"  | while read i
      do
        native2ascii -reverse $i $i.new && mv $i.new $i
      done

----


---

[GitHub] jmeter pull request #437: Native properties

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/437


---

[GitHub] jmeter issue #437: Native properties

[pmouawad <gi...@git.apache.org>]

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/437
  
    +1, Thanks



---