You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/06 08:26:52 UTC

[GitHub] [ignite] timoninmaxim commented on a change in pull request #9604: IGNITE-11402 SQL: Add ability to specify inline size of PK and affini…

timoninmaxim commented on a change in pull request #9604:
URL: https://github.com/apache/ignite/pull/9604#discussion_r762787886



##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2TableDescriptor.java
##########
@@ -325,7 +325,7 @@ GridLuceneIndex luceneIndex() {
     @NotNull private List<IndexColumn> extractKeyColumns(GridH2Table tbl, IndexColumn keyCol, IndexColumn affCol) {
         ArrayList<IndexColumn> keyCols;
 
-        if (isSql) {

Review comment:
       Hi! `H2TableDescriptor#sql()` also is used in `H2Utils#unwrapKeyColumns` for indexes information. Should we change logic there too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org