You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Todd de Quincey (Jira)" <ji...@apache.org> on 2020/02/10 08:28:00 UTC

[jira] [Comment Edited] (AIRFLOW-6732) Add Google Ads operators

    [ https://issues.apache.org/jira/browse/AIRFLOW-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033431#comment-17033431 ] 

Todd de Quincey edited comment on AIRFLOW-6732 at 2/10/20 8:27 AM:
-------------------------------------------------------------------

We didn't implement a GetAccounts operator. For our use case, we simply created a GoogleAdsHook and a GoogleAdsToGcsOperator which accepts the Google Ads Query Language (SQL like syntax) and stores the results in a CSV in the specified GCS bucket. But based on the hook, this should be easy to implement. 

Yep, we provided authentication via the yaml config file. This requires two connections to be setup in Airflow. 1) google_ads_default and 2) google_cloud_default. 

I should be finished with the tidy up of the code that I need to do in a few weeks. Presuming you aren't in too much of a rush at this stage?


was (Author: toddy86):
We didn't implement a GetAccounts operator. For our use case, we simply created a GoogleAdsHook and a GoogleAdsToGcsOperator which accepts the Google Ads Query Language (SQL like syntax) and stores the results in a CSV in the specified GCS bucket. But based on the hook, this should be easy to implement. 

Yep, we provided authentication via the yaml config file. This requires two connections to be setup in Airflow. 1) `google_ads_default` and 2) `google_cloud_default`. 

I should be finished with the tidy up of the code that I need to do in a few weeks. Presuming you aren't in too much of a rush at this stage?

> Add Google Ads operators
> ------------------------
>
>                 Key: AIRFLOW-6732
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6732
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: gcp, operators
>    Affects Versions: 2.0.0
>            Reporter: Tomasz Urbaszek
>            Assignee: Todd de Quincey
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)