[jira] [Commented] (ACCUMULO-3725) Majc trace tacked onto minc trace

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494437#comment-14494437 ] 

Josh Elser commented on ACCUMULO-3725:
--------------------------------------

I just tested out a quick patch Billie whipped up and sent me that moves the annotations up into the try-block and copies the span.close() into the try block as well (leaving the span.close() also in the finally block). This appears to work as expected when running a short continuous ingest.

> Majc trace tacked onto minc trace
> ---------------------------------
>
>                 Key: ACCUMULO-3725
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3725
>             Project: Accumulo
>          Issue Type: Bug
>          Components: trace
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: 1.7.0
>
>
> [~elserj] noticed an issue where a minorCompaction trace of length 10295 ms also contained spans for a major compaction starting at time offset 46336 ms.  Looking into this, it seems like MinorCompactionTask.run does the following:
> {noformat}
> start minc root span
> try {
>   minor compaction
>   maybe major compaction
> } finally {
>   stop minc root span
> }
> {noformat}
> The major compaction is async, so it gets initiated with the minor compaction span as its parent, then the minor compaction span is stopped, and at some point later the major compaction occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)