[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8563: WiP: Moving static colors over to Less vars

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8563: WiP: Moving static colors over to Less vars
URL: https://github.com/apache/incubator-superset/pull/8563#discussion_r346466597
 
 

 ##########
 File path: superset/assets/src/SqlLab/main.less
 ##########
 @@ -60,7 +61,7 @@ body {
 }
 
 .Workspace .btn-sm {
-    box-shadow: 1px 1px 2px rgba(0, 0, 0, 0.1);
+    box-shadow: 1px 1px 2px fade(@darkest, 10%);
 
 Review comment:
   instead of all these `fade(@darkest`s do you think we should instead define all the valid versions of translucent black in the variables file, thus limiting to only certain standard transparency stops?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org