You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/08 06:45:36 UTC
[GitHub] flink pull request #4288: [FLINK-7111] [scala-shell] Disable external jar te...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4288
[FLINK-7111] [scala-shell] Disable external jar test
@aljoscha What do you think?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7111
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4288
----
commit a301d5bad836964ab25973a5bf2a82b78e670b6b
Author: zentol <ch...@apache.org>
Date: 2017-07-08T06:44:05Z
[FLINK-7111] [scala-shell] Disable external jar test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4288: [FLINK-7111] [scala-shell] Disable external jar test
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4288
sure. I'll fix the typo while merging, thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4288: [FLINK-7111] [scala-shell] Disable external jar te...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4288#discussion_r126631682
--- Diff: flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITCase.scala ---
@@ -164,7 +164,11 @@ class ScalaShellITCase extends TestLogger {
Assert.assertTrue(output.contains("WC(world,10)"))
}
- /** Submit external library */
+ /**
+ * Submit external library.
+ * Disabled due of FLINK-7111.
--- End diff --
Should this be "due to"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4288: [FLINK-7111] [scala-shell] Disable external jar test
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4288
This looks good! 👍
Could you please add a (possibly blocking) issue for re-enabling this test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4288: [FLINK-7111] [scala-shell] Disable external jar te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---