You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2026/05/14 09:01:43 UTC
[PR] fix(api): unredact import error stacktrace for unscoped Dag readers [airflow]
Lee-W opened a new pull request, #66923:
URL: https://github.com/apache/airflow/pull/66923
When an import error refers to a file with no matching DagModel rows (e.g., a new Dag file that failed to parse before any Dag was defined), the stacktrace was always redacted because there is no per-Dag anchor to authorize against. This blocked the common "new Dag failed to parse" debugging flow even for callers with unscoped Dag read access (admin-like roles).
Now the stacktrace is only redacted for per-Dag-scoped readers; callers authorized to read any Dag get the raw stacktrace, since they have nothing new to learn from redaction.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(api): unredact import error stacktrace for unscoped Dag readers [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #66923:
URL: https://github.com/apache/airflow/pull/66923#discussion_r3240895662
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py:
##########
@@ -98,11 +98,13 @@ def get_import_error(
# No Dags matched for this file -- either the file genuinely contains
# no Dags (parse failed before any Dag was defined), or the name keys
- # did not resolve. Redact the stacktrace rather than returning the raw
- # error, so the response stays on the deny-by-default side of the
- # authorization check.
+ # did not resolve. There is no per-Dag content to gate on, so trust
+ # callers with unscoped Dag read access (admin-like roles) and only
+ # redact for per-Dag-scoped readers, which we cannot validate without
+ # a Dag anchor.
if not file_dag_ids:
- error.stacktrace = REDACTED_STACKTRACE
+ if not auth_manager.is_authorized_dag(method="GET", user=user):
Review Comment:
wrong fix. took a deeper look. It seems there's no easy fix based on the current design. I'll change it to a message changing only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use a distinct redact message for import errors with no registered Dag [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66923:
URL: https://github.com/apache/airflow/pull/66923#issuecomment-4487620156
Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to **[Airflow 3.2.2](https://github.com/apache/airflow/milestone/138)** based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.
> This comment was generated by [Milestone Tag Assistant](https://github.com/apache/airflow/blob/main/.github/workflows/milestone-tag-assistant.yml).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(api): unredact import error stacktrace for unscoped Dag readers [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #66923:
URL: https://github.com/apache/airflow/pull/66923#discussion_r3240812937
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py:
##########
@@ -98,11 +98,13 @@ def get_import_error(
# No Dags matched for this file -- either the file genuinely contains
# no Dags (parse failed before any Dag was defined), or the name keys
- # did not resolve. Redact the stacktrace rather than returning the raw
- # error, so the response stays on the deny-by-default side of the
- # authorization check.
+ # did not resolve. There is no per-Dag content to gate on, so trust
+ # callers with unscoped Dag read access (admin-like roles) and only
+ # redact for per-Dag-scoped readers, which we cannot validate without
+ # a Dag anchor.
if not file_dag_ids:
- error.stacktrace = REDACTED_STACKTRACE
+ if not auth_manager.is_authorized_dag(method="GET", user=user):
Review Comment:
With this change, a user whose only permission is `can_read` on DAG:`foo` would now get the raw stacktrace of any failing-to-parse file, including files they have no permission to read.
cc @vincbeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use a distinct redact message for import errors with no registered Dag [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66923:
URL: https://github.com/apache/airflow/pull/66923#issuecomment-4487630636
### Backport successfully created: v3-2-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/pull/67176"><img src="https://img.shields.io/badge/PR-67176-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use a distinct redact message for import errors with no registered Dag [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #66923:
URL: https://github.com/apache/airflow/pull/66923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org