You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/19 12:07:44 UTC
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16917: [improve][txn][PIP-196]Segmented transaction buffer snapshot configuration
codelipenghui commented on code in PR #16917:
URL: https://github.com/apache/pulsar/pull/16917#discussion_r974171995
##########
conf/broker.conf:
##########
@@ -1497,12 +1497,22 @@ transactionCoordinatorEnabled=false
transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider
# Transaction buffer takes a snapshot after the number of transaction operations reaches this value.
+# If transaction buffer enables snapshot segment, transaction buffer updates snapshot metadata
+# after the number of transaction operations reaches this value.
transactionBufferSnapshotMaxTransactionCount=1000
-# Transaction buffer take snapshot interval time
+# The interval time for transaction buffer to take snapshots.
+# If transaction buffer enables snapshot segment, it is the interval time for transaction buffer to update snapshot metadata.
# Unit : millisecond
transactionBufferSnapshotMinTimeInMillis=5000
+# Whether to enable segmented transaction buffer snapshot to handle a large number of aborted transactions.
+transactionBufferSegmentedSnapshotEnabled = false
Review Comment:
```suggestion
transactionBufferSegmentedSnapshotEnabled=false
```
##########
conf/standalone.conf:
##########
@@ -1108,12 +1108,22 @@ transactionCoordinatorEnabled=false
transactionMetadataStoreProviderClassName=org.apache.pulsar.transaction.coordinator.impl.MLTransactionMetadataStoreProvider
# Transaction buffer takes a snapshot after the number of transaction operations reaches this value.
+# If transaction buffer enables snapshot segment, transaction buffer updates snapshot metadata
+# after the number of transaction operations reaches this value.
transactionBufferSnapshotMaxTransactionCount=1000
-# Transaction buffer take snapshot interval time
+# The interval time for transaction buffer to take snapshots.
+# If transaction buffer enables snapshot segment, it is the interval time for transaction buffer to update snapshot metadata.
# Unit : millisecond
transactionBufferSnapshotMinTimeInMillis=5000
+# Whether to enable segmented transaction buffer snapshot to handle a large number of aborted transactions.
+transactionBufferSegmentedSnapshotEnabled = false
Review Comment:
```suggestion
transactionBufferSegmentedSnapshotEnabled=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org