[jira] Commented: (HARMONY-6095) [classlib][luni] Performance improvement patch for java.text.DateFormatSymbols.DateFormatSymbols(Locale)

["Tony Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-6095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676549#action_12676549 ] 

Tony Wu commented on HARMONY-6095:
----------------------------------

Hi Deven

Can you integrate your testcases to your patch as well so that it could be granted the permission to apache.
It is suggeted to write in the same pattern as our existing serialization tests, you can refer to DecimalFormatSymbolsTest or others.


> [classlib][luni] Performance improvement patch for java.text.DateFormatSymbols.DateFormatSymbols(Locale)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6095
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6095
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: deven you
>            Assignee: Tony Wu
>         Attachments: hy-text.diff, hy-text_v2.diff
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> this constructor spend much time on getZoneString(), howerver it is rarely used in real world application. so I just delay loading the ZoneStrings 
> the testcase is :
> import java.text.DateFormatSymbols;
> import java.util.Locale;
> public class TestDateFormatSymbols {
>     public static void main(String[] args) {
>         long time = System.currentTimeMillis();
>         DateFormatSymbols dfs = new DateFormatSymbols(Locale.getDefault());
>         time = System.currentTimeMillis() - time;
>         
>         System.out.println("the total time is " + time + " ms!");
>     }
> }
> I have test on on Intel(R) Core(TM)2 Duo Cpu 2.4GHZ, 2.98GB Memory machine, the result is as below:
> Harmony patch before: 1125 ms
> > Harmony patched: 78 ms

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.