You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by kiszk <gi...@git.apache.org> on 2018/02/25 19:20:29 UTC

[GitHub] spark pull request #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2...

GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/20672

    [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

    ## What changes were proposed in this pull request?
    
    This PR avoids version conflicts of `commons-net`. We are seeing the following message during the build using sbt.
    
    ```
    [warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
    ...
    [warn] 	* commons-net:commons-net:3.1 is selected over 2.2
    [warn] 	    +- org.apache.hadoop:hadoop-common:2.6.5              (depends on 3.1)
    [warn] 	    +- org.apache.spark:spark-core_2.11:2.4.0-SNAPSHOT    (depends on 2.2)
    [warn]
    ```
    
    [Here](https://commons.apache.org/proper/commons-net/changes-report.html) is a release history.  
    
    [Here](https://commons.apache.org/proper/commons-net/migration.html) is a migration guide from 2.x to 3.0 and from 3.x to 3.5.
    
    
    ## How was this patch tested?
    
    Existing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-23509

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20672
    
----
commit 97a254040009f18faf2641a60891d24bb618737c
Author: Kazuaki Ishizaki <is...@...>
Date:   2018-02-25T19:06:54Z

    initial commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87656/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    cc @srowen


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87655/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    **[Test build #87655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87655/testReport)** for PR 20672 at commit [`97a2540`](https://github.com/apache/spark/commit/97a254040009f18faf2641a60891d24bb618737c).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1043/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1042/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    Merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    **[Test build #87656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87656/testReport)** for PR 20672 at commit [`745f9f9`](https://github.com/apache/spark/commit/745f9f9c6fc7dbc2f5b69cd87ab41392d16cfca2).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    **[Test build #87655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87655/testReport)** for PR 20672 at commit [`97a2540`](https://github.com/apache/spark/commit/97a254040009f18faf2641a60891d24bb618737c).
     * This patch **fails build dependency tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20672: [SPARK-23509][Build] Upgrade commons-net from 2.2 to 3.1

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20672
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org