[kudu] branch master updated: rpc-test: deflake TestClientConnectionMetrics

[ad...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 253e136  rpc-test: deflake TestClientConnectionMetrics
253e136 is described below

commit 253e136061834484c19518de4f1741d5ee5ab7df
Author: Adar Dembo <ad...@cloudera.com>
AuthorDate: Thu Jun 6 12:02:11 2019 -0700

    rpc-test: deflake TestClientConnectionMetrics
    
    Looks like send_bytes_per_sec can overflow:
    
      /home/jenkins-slave/workspace/kudu-master/2/src/kudu/rpc/rpc-test.cc:552
      Expected: (conn.socket_stats().send_bytes_per_sec()) > (0), actual: -800244607 vs 0
    
    The code in 'ss' (which inspired this calculation) uses double arithmetic,
    but we'll settle for int64, which should be good enough.
    
    Change-Id: I705711a53a6b588c4c164990506c530c8bd6116f
    Reviewed-on: http://gerrit.cloudera.org:8080/13543
    Reviewed-by: Todd Lipcon <to...@apache.org>
    Tested-by: Adar Dembo <ad...@cloudera.com>
---
 src/kudu/rpc/rpc_introspection.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/rpc/rpc_introspection.proto b/src/kudu/rpc/rpc_introspection.proto
index 05be722..57e00ad 100644
--- a/src/kudu/rpc/rpc_introspection.proto
+++ b/src/kudu/rpc/rpc_introspection.proto
@@ -73,7 +73,7 @@ message SocketStatsPB {
   optional uint64 receive_queue_bytes = 12;
 
   // Calculated sender throughput.
-  optional int32 send_bytes_per_sec = 13;
+  optional int64 send_bytes_per_sec = 13;
 };
 
 // Debugging information about a currently-open RPC connection.