You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/14 13:06:20 UTC

[GitHub] gaborgsomogyi commented on a change in pull request #23784: [SPARK-26870][SQL] Move to_avro/from_avro into functions object due to Java compatibility

gaborgsomogyi commented on a change in pull request #23784: [SPARK-26870][SQL] Move to_avro/from_avro into functions object due to Java compatibility
URL: https://github.com/apache/spark/pull/23784#discussion_r256821443
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala
 ##########
 @@ -67,7 +65,7 @@ package object avro {
    * @since 2.4.0
    */
   @Experimental
-  def to_avro(data: Column): Column = {
-    new Column(CatalystDataToAvro(data.expr))
-  }
+  @deprecated("Please use 'org.apache.spark.sql.avro.functions.to_avro' instead.", "3.0.0")
+  def to_avro(data: Column): Column =
+    org.apache.spark.sql.avro.functions.to_avro(data)
 
 Review comment:
   Nit: No line break necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org