[GitHub] [dubbo-go] zouyx commented on a change in pull request #854: Impl: support extension of two urls comparison.

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #854:
URL: https://github.com/apache/dubbo-go/pull/854#discussion_r545543970



##########
File path: common/url.go
##########
@@ -770,3 +775,21 @@ func (s URLSlice) Less(i, j int) bool {
 func (s URLSlice) Swap(i, j int) {
 	s[i], s[j] = s[j], s[i]
 }
+
+type CompareURLEqualFunc func(l *URL, r *URL, excludeParam ...string) bool
+
+func defaultCompareURLEqual(l *URL, r *URL, excludeParam ...string) bool {
+	return IsEquals(l, r, excludeParam...)
+}
+
+func init() {

Review comment:
       move to the top of this file




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org