You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/10/09 16:37:14 UTC
[PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
mapleFU opened a new pull request, #38163:
URL: https://github.com/apache/arrow/pull/38163
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Only use RLE as BOOLEAN default encoding when data page is V2
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Tiny change
### Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
RLE encoding change for Boolean.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #38163:
URL: https://github.com/apache/arrow/pull/38163#issuecomment-1755067429
@pitrou @jorisvandenbossche @wgtmac Would you mind take a look? Would this ok? Or just write RLE as default on V1 data page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #38163:
URL: https://github.com/apache/arrow/pull/38163#discussion_r1351131869
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2336,7 +2336,8 @@ std::shared_ptr<ColumnWriter> ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
Encoding::type encoding = properties->encoding(descr->path());
if (encoding == Encoding::UNKNOWN) {
encoding = (descr->physical_type() == Type::BOOLEAN &&
- properties->version() != ParquetVersion::PARQUET_1_0)
+ properties->version() != ParquetVersion::PARQUET_1_0 &&
+ properties->data_page_version() == ParquetDataPageVersion::V2)
Review Comment:
IIUC, if the data page version is v2, it is user's responsibility to set parquet version to PARQUET_2_X. Unfortunately, this is not enforced yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #38163:
URL: https://github.com/apache/arrow/pull/38163#issuecomment-1754162274
@mapleFU There are CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #38163:
URL: https://github.com/apache/arrow/pull/38163#issuecomment-1755675132
I've resolve the comment and update the description @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38163:
URL: https://github.com/apache/arrow/pull/38163#issuecomment-1760928350
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 64c7caea0cf0002017bd3922147fe5a831cfaecd.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/17666724759) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #38163:
URL: https://github.com/apache/arrow/pull/38163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #38163:
URL: https://github.com/apache/arrow/pull/38163#issuecomment-1755627362
Can you update the PR description to explain the rationale for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #38163:
URL: https://github.com/apache/arrow/pull/38163#discussion_r1351285015
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2336,7 +2336,8 @@ std::shared_ptr<ColumnWriter> ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
Encoding::type encoding = properties->encoding(descr->path());
if (encoding == Encoding::UNKNOWN) {
encoding = (descr->physical_type() == Type::BOOLEAN &&
- properties->version() != ParquetVersion::PARQUET_1_0)
+ properties->version() != ParquetVersion::PARQUET_1_0 &&
+ properties->data_page_version() == ParquetDataPageVersion::V2)
Review Comment:
Should we prevent from this or just keep the behavior here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #38163:
URL: https://github.com/apache/arrow/pull/38163#discussion_r1352747786
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -767,9 +784,12 @@ TEST_F(TestValuesWriterInt32Type, OptionalNullValueChunk) {
class TestBooleanValuesWriter : public TestPrimitiveWriter<BooleanType> {
public:
- void TestWithEncoding(ParquetVersion::type version, Encoding::type encoding) {
+ void TestWithEncoding(ParquetVersion::type version,
+ ParquetDataPageVersion data_page_version,
+ Encoding::type encoding) {
this->SetUpSchema(Repetition::REQUIRED);
auto writer = this->BuildWriter(SMALL_SIZE, ColumnProperties(), version,
+ ParquetDataPageVersion::V1,
Review Comment:
Why not `data_page_version`?
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -789,12 +809,18 @@ class TestBooleanValuesWriter : public TestPrimitiveWriter<BooleanType> {
// PARQUET-764
// Correct bitpacking for boolean write at non-byte boundaries
TEST_F(TestBooleanValuesWriter, AlternateBooleanValues) {
- TestWithEncoding(ParquetVersion::PARQUET_1_0, Encoding::PLAIN);
+ for (auto data_page_version :
+ {ParquetDataPageVersion::V1, ParquetDataPageVersion::V2}) {
+ TestWithEncoding(ParquetVersion::PARQUET_1_0, data_page_version, Encoding::PLAIN);
+ }
}
// Default encoding for boolean is RLE when using V2 pages
TEST_F(TestBooleanValuesWriter, RleEncodedBooleanValues) {
- TestWithEncoding(ParquetVersion::PARQUET_2_4, Encoding::RLE);
+ TestWithEncoding(ParquetVersion::PARQUET_2_4, ParquetDataPageVersion::V1,
+ Encoding::PLAIN);
+ TestWithEncoding(ParquetVersion::PARQUET_2_4, ParquetDataPageVersion::V2,
+ Encoding::RLE);
Review Comment:
Well, `RLE` is always in the encodings regardless, since it's used to RL/DL, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-36882: [C++][Parquet] Use RLE as BOOLEAN default encoding when both data page and version is V2 [arrow]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #38163:
URL: https://github.com/apache/arrow/pull/38163#discussion_r1351297220
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2336,7 +2336,8 @@ std::shared_ptr<ColumnWriter> ColumnWriter::Make(ColumnChunkMetaDataBuilder* met
Encoding::type encoding = properties->encoding(descr->path());
if (encoding == Encoding::UNKNOWN) {
encoding = (descr->physical_type() == Type::BOOLEAN &&
- properties->version() != ParquetVersion::PARQUET_1_0)
+ properties->version() != ParquetVersion::PARQUET_1_0 &&
+ properties->data_page_version() == ParquetDataPageVersion::V2)
Review Comment:
Let's do it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org