[GitHub] [arrow] tyrelr commented on a change in pull request #9440: ARROW-11546: [Rust][Experiment][WIP] Experiment with a TypedArray trait

[GitBox <gi...@apache.org>]

tyrelr commented on a change in pull request #9440:
URL: https://github.com/apache/arrow/pull/9440#discussion_r571706825



##########
File path: rust/arrow/src/array/array_binary.rs
##########
@@ -162,6 +163,16 @@ impl<OffsetSize: BinaryOffsetSizeTrait> GenericBinaryArray<OffsetSize> {
     }
 }
 
+impl<'a, OffsetSize: BinaryOffsetSizeTrait> TypedArray
+    for &'a GenericBinaryArray<OffsetSize>

Review comment:
       I had initially hoped to make TypedArray an extension of the Array trait.  But, to use a lifetime in the 'type' declarations, I found that I needed to either make TypedArray include a generic lifetime (TypedArray<'a>), or I needed to implement it for &'a TypedArray.
   
   My previous attempts at this tried to use `trait TypedArray<'a> : Array`, but once I tried using it on the comparison kernels ' I hit on lifetime issues trying to prove the equivalence of NativeTypes... so I'm keeping it simple for the experiment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org