You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2009/05/14 00:36:45 UTC
[jira] Created: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
zookeeper c library segfaults on data for a node in zookeeper being null.
-------------------------------------------------------------------------
Key: ZOOKEEPER-402
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
Project: Zookeeper
Issue Type: Bug
Affects Versions: 3.1.1, 3.1.0
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.2.0
the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711888#action_12711888 ]
Hudson commented on ZOOKEEPER-402:
----------------------------------
Integrated in ZooKeeper-trunk #321 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])
. zookeeper c library segfaults on data for a node in zookeeper being null
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-402:
------------------------------------
Attachment: ZOOKEEPER-402.patch
this patch fixes the issue with NULL being compatible in both java and c. Added a test in c as well...
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-402:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 looks good. thanks Mahadev
Committed revision 777265.
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-402:
------------------------------------
Status: Patch Available (was: Open)
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-402:
-----------------------------------
Status: Open (was: Patch Available)
The specific changes look good, however I think we should include the following:
1) I don't see this documented in zookeeper.h api docs, please update the api docs for create/set/get
2) the tests should test all methods - set for example is not tested
What methods are impacted? create/get/set, that's it? Do the async versions of the methods
also need to be tested, or is that covered by the sync?
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-402:
------------------------------------
Status: Patch Available (was: Open)
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-402:
------------------------------------
Attachment: ZOOKEEPER-402.patch
removed the path, from the patch...
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709185#action_12709185 ]
Mahadev konar commented on ZOOKEEPER-402:
-----------------------------------------
here is the code that seg faults:
{code}
len = res.data.len;
1628 } else {
1629 len = sc->u.data.buff_len;
1630 }
1631 sc->u.data.buff_len = len;
1632 memcpy(sc->u.data.buffer, res.data.buff, len);
1633 sc->u.data.stat = res.stat;
1634 deallocate_GetDataResponse(&res);
{code}
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-402:
------------------------------------
Status: Open (was: Patch Available)
you have a hard coded path that is specific to your machine mahadev.
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-402:
------------------------------------
Attachment: ZOOKEEPER-402.patch
valid points pat...
- added comments to zookeeper.h
- added test for zoo_set
- also, the async apis are tested via athe sync apis.
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710606#action_12710606 ]
Mahadev konar commented on ZOOKEEPER-402:
-----------------------------------------
ok this took me a while to figure out, since its a weird corner case. The c library as it is supports NULL. So you can do a create of a node with NULL and read it back. This will work. But the problem arises when you do a create with the java client with data as NULL and read it from the c client. The other way round works fine. The problem being that the java code serializes the NULL buffer as -1 and the c code does it with serializing as 0 and does not handle -1 on deserialization or serialization. We should fix the c recordio to handle this. Ill upload a patch soon.
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711527#action_12711527 ]
Hadoop QA commented on ZOOKEEPER-402:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408622/ZOOKEEPER-402.patch
against trunk revision 776889.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/console
This message is automatically generated.
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.0, 3.1.1
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on
data for a node in zookeeper being null.
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-402:
------------------------------------
Status: Patch Available (was: Open)
> zookeeper c library segfaults on data for a node in zookeeper being null.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-402
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.1.1, 3.1.0
> Reporter: Mahadev konar
> Assignee: Mahadev konar
> Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch
>
>
> the zookeeper c client library seg faults on data being null for a zoo node.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.