You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Justin Bertram (Jira)" <ji...@apache.org> on 2019/09/03 20:11:00 UTC
[jira] [Commented] (ARTEMIS-2460) Open file descriptors leak for
large messages
[ https://issues.apache.org/jira/browse/ARTEMIS-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921701#comment-16921701 ]
Justin Bertram commented on ARTEMIS-2460:
-----------------------------------------
My concern with the fix is that the file is being closed by a method that isn't opening it which leaves the possibility that some other bit of code will expect the file to be open when now it will be closed. Also, since there's no test-case there's no way to confirm this fix is valid or protect against possible future regressions. Ideally the code that opened the file in the first place would be responsible for closing it and there would be a test-case as well.
> Open file descriptors leak for large messages
> ---------------------------------------------
>
> Key: ARTEMIS-2460
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2460
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
> Affects Versions: 2.9.0
> Reporter: Rakesh Chandru
> Assignee: Justin Bertram
> Priority: Major
>
>
> There is a significant increase in case of open file descriptors when publishing large messages. This behaviour is also see with the latest 2.9.0 version.
> {code:java}
> java 38082 root 9486u REG 8,4 909757 19146486 /xxx/data/large-messages/31297137237.msg (deleted)
> java 38082 root 9489u REG 8,4 605189 19146488 /xxx/data/large-messages/31297137344.msg (deleted){code}
> The reference is kept to the deleted large message file
> Below is the log trace.
> {noformat}
> 2019-07-23 05:00:10 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Opening large message file(openFile-512) with message-id=19,826,804,644
> 2019-07-23 05:00:10 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Closing large message file(releaseResources-341) with message-id=19,826,804,644
> 2019-07-23 05:03:51 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Opening large message file(openFile-512) with message-id=19,826,804,644
> 2019-07-23 05:03:51 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Opening decoding context file for large message with message-id=19,826,804,644
> 2019-07-23 05:03:51 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Closing decoding context file for large message with message-id=19,826,804,644
> 2019-07-23 05:03:52 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Opening large message file(openFile-512) with message-id=19,826,804,644
> 2019-07-23 05:03:52 TRACE [org.apache.activemq.artemis.core.persistence.impl.journal.JournalStorageManager] Closing large message file(releaseResources-341) with message-id=19,826,804,644
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)