You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Tsuyoshi OZAWA (JIRA)" <ji...@apache.org> on 2014/04/22 17:22:14 UTC
[jira] [Comment Edited] (TEZ-373) Create UserPayload class
[ https://issues.apache.org/jira/browse/TEZ-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976904#comment-13976904 ]
Tsuyoshi OZAWA edited comment on TEZ-373 at 4/22/14 3:20 PM:
-------------------------------------------------------------
Changed to use TezUserPayload, which includes in UserPayload.proto, for internal code with TezZeroCopyByteString. TezZeroCopyByteString is a class copied from HBaseZeroCopyByteString for restricting copies related to probobuf objects. TezUserPayload is assumed to be created by TezUserPayloadFactory because TezUserPayload fields can be null.
TezEvent.java, ProtoConverters.java can use TezZeroCopyByteString to reduce copies, but it's out of scope of this JIRA. I'll fix the problem about adding dependency on Nullable annotation on TEZ-886.
I confirmed to pass tests with this patch. [~bikassaha], can you take a look please?
was (Author: ozawa):
Changed to use TezUserPayload, which incluedes in UserPayload.proto, for internal code with TezZeroCopyByteString. TezZeroCopyByteString is class from HBaseZeroCopyByteString for restricting copies related to probobuf objects. TezUserPayload is assumed to be created by TezUserPayloadFactory because TezUserPayload fields can be null.
TezEvent.java, ProtoConverters.java can use TezZeroCopyByteString to reduce copies, but it's out of scope of this JIRA. I'll fix the problem about adding dependency on Nullable annotation on TEZ-886.
I confirmed to pass tests with this patch. [~bikassaha], can you take a look please?
> Create UserPayload class
> ------------------------
>
> Key: TEZ-373
> URL: https://issues.apache.org/jira/browse/TEZ-373
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Tsuyoshi OZAWA
> Labels: newbie
> Attachments: TEZ-373.1.patch, TEZ-373.2.patch, TEZ-373.3.patch, TEZ-373.4.patch, TEZ-373.5.patch, TEZ-373.6.patch
>
>
> Currently Tez allows user payload to be passed as byte[]. Within Tez code is hard to understand where byte[] is userPayload and where is not user payload. If we create a TezUserPayload class that contains byte[] as a member then its much easier to search and identify in code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)