You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/07 19:10:03 UTC
[GitHub] [arrow] bmschmidt opened a new pull request #8385: fix toArray() to handle null values
bmschmidt opened a new pull request #8385:
URL: https://github.com/apache/arrow/pull/8385
Remove fast method that ignores null values. JIRA issued filed. A better version might use the old method if the vector is guaranteed not to be nullable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-826370150
Yes, I think this is https://issues.apache.org/jira/browse/ARROW-10221. @bmschmidt do you have time to finish up this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-705764977
https://issues.apache.org/jira/browse/ARROW-10220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] TheNeuralBit commented on a change in pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#discussion_r562374331
##########
File path: js/src/visitor/toarray.ts
##########
@@ -88,18 +88,6 @@ export class ToArrayVisitor extends Visitor {}
/** @ignore */
function arrayOfVector<T extends DataType>(vector: VectorType<T>): T['TArray'] {
-
- const { type, length, stride } = vector;
-
- // Fast case, return subarray if possible
- switch (type.typeId) {
Review comment:
Instead of removing the fast case can you just add a check to skip this if the type is nullable? As you pointed out in the jira we could still do this for non-nullable arrays.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] TheNeuralBit commented on a change in pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#discussion_r562374331
##########
File path: js/src/visitor/toarray.ts
##########
@@ -88,18 +88,6 @@ export class ToArrayVisitor extends Visitor {}
/** @ignore */
function arrayOfVector<T extends DataType>(vector: VectorType<T>): T['TArray'] {
-
- const { type, length, stride } = vector;
-
- // Fast case, return subarray if possible
- switch (type.typeId) {
Review comment:
Instead of removing the fast case can you just add a check to skip this if the type is nullable? As you pointed out in the jira we could still do this for non-nullable arrays.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed pull request #8385: ARROW-10221: [JS] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #8385:
URL: https://github.com/apache/arrow/pull/8385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-826371892
Can you change the title to `ARROW-10220: [JS] toArray() method ignores nulls on some types` so that the correct label `lang-js` is added to the pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8385: ARROW-10221: [JS] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-826931220
https://issues.apache.org/jira/browse/ARROW-10221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-705764977
https://issues.apache.org/jira/browse/ARROW-10220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8385: fix toArray() to handle null values
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-705144305
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #8385: ARROW-10220 [Javascript] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-826370150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz edited a comment on pull request #8385: ARROW-10221: [JS] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
domoritz edited a comment on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-1014091274
I think this needs to be redone since the code has changed a bit. I want to make sure we make the right decision about the behavior. See https://issues.apache.org/jira/browse/ARROW-10221 for my comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #8385: ARROW-10221: [JS] Javascript toArray() method ignores nulls on some types.
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #8385:
URL: https://github.com/apache/arrow/pull/8385#issuecomment-1014091274
I think this needs to be redone. I want to make sure we make the right decision about the behavior. See https://issues.apache.org/jira/browse/ARROW-10221 for my comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org