You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/05/30 00:44:44 UTC

[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3011: [SCB-2535] Bump brave.version from 5.6.11 to 5.13.9

Shoothzj commented on code in PR #3011:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3011#discussion_r884349736


##########
tracing/tracing-zipkin/src/test/java/org/apache/servicecomb/tracing/zipkin/ZipkinTracingAdviserTest.java:
##########
@@ -134,11 +146,11 @@ public void startsNewChildSpan() {
 
     MatcherAssert.assertThat(traces.size(), is(nThreads));
 
-    for (Queue<zipkin2.Span> queue : traces.values()) {
-      zipkin2.Span child = queue.poll();
+    for (Queue<MutableSpan> queue : traces.values()) {
+      MutableSpan parent = queue.poll();

Review Comment:
   Why change the `poll` order, is this change compatible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org