You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/10/12 11:01:46 UTC
[GitHub] [fineract] galovics commented on a diff in pull request #2657: FINERACT-1770: Introduce Lombok to sms module
galovics commented on code in PR #2657:
URL: https://github.com/apache/fineract/pull/2657#discussion_r993311419
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessage.java:
##########
@@ -86,39 +93,26 @@ public class SmsMessage extends AbstractPersistableCustom {
public static SmsMessage pendingSms(final String externalId, final Group group, final Client client, final Staff staff,
final String message, final String mobileNo, final SmsCampaign smsCampaign, final boolean isNotification) {
- return new SmsMessage(externalId, group, client, staff, SmsMessageStatusType.PENDING, message, mobileNo, smsCampaign,
- isNotification);
+ return new SmsMessage().setExternalId(externalId).setGroup(group).setClient(client).setStaff(staff)
+ .setStatusType(SmsMessageStatusType.PENDING.getValue()).setMessage(message).setMobileNo(mobileNo)
+ .setSmsCampaign(smsCampaign).setNotification(isNotification);
}
public static SmsMessage sentSms(final String externalId, final Group group, final Client client, final Staff staff,
final String message, final String mobileNo, final SmsCampaign smsCampaign, final boolean isNotification) {
- return new SmsMessage(externalId, group, client, staff, SmsMessageStatusType.WAITING_FOR_DELIVERY_REPORT, message, mobileNo,
- smsCampaign, isNotification);
+ return new SmsMessage().setExternalId(externalId).setGroup(group).setClient(client).setStaff(staff)
Review Comment:
Missing: `this.submittedOnDate = DateUtils.getBusinessLocalDate();`
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessage.java:
##########
@@ -86,39 +93,26 @@ public class SmsMessage extends AbstractPersistableCustom {
public static SmsMessage pendingSms(final String externalId, final Group group, final Client client, final Staff staff,
final String message, final String mobileNo, final SmsCampaign smsCampaign, final boolean isNotification) {
- return new SmsMessage(externalId, group, client, staff, SmsMessageStatusType.PENDING, message, mobileNo, smsCampaign,
- isNotification);
+ return new SmsMessage().setExternalId(externalId).setGroup(group).setClient(client).setStaff(staff)
Review Comment:
Missing: `this.submittedOnDate = DateUtils.getBusinessLocalDate();`
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/domain/SmsMessage.java:
##########
@@ -86,39 +93,26 @@ public class SmsMessage extends AbstractPersistableCustom {
public static SmsMessage pendingSms(final String externalId, final Group group, final Client client, final Staff staff,
final String message, final String mobileNo, final SmsCampaign smsCampaign, final boolean isNotification) {
- return new SmsMessage(externalId, group, client, staff, SmsMessageStatusType.PENDING, message, mobileNo, smsCampaign,
- isNotification);
+ return new SmsMessage().setExternalId(externalId).setGroup(group).setClient(client).setStaff(staff)
+ .setStatusType(SmsMessageStatusType.PENDING.getValue()).setMessage(message).setMobileNo(mobileNo)
+ .setSmsCampaign(smsCampaign).setNotification(isNotification);
}
public static SmsMessage sentSms(final String externalId, final Group group, final Client client, final Staff staff,
final String message, final String mobileNo, final SmsCampaign smsCampaign, final boolean isNotification) {
- return new SmsMessage(externalId, group, client, staff, SmsMessageStatusType.WAITING_FOR_DELIVERY_REPORT, message, mobileNo,
- smsCampaign, isNotification);
+ return new SmsMessage().setExternalId(externalId).setGroup(group).setClient(client).setStaff(staff)
+ .setStatusType(SmsMessageStatusType.WAITING_FOR_DELIVERY_REPORT.getValue()).setMessage(message).setMobileNo(mobileNo)
+ .setSmsCampaign(smsCampaign).setNotification(isNotification);
}
public static SmsMessage instance(String externalId, final Group group, final Client client, final Staff staff,
final SmsMessageStatusType statusType, final String message, final String mobileNo, final SmsCampaign smsCampaign,
final boolean isNotification) {
- return new SmsMessage(externalId, group, client, staff, statusType, message, mobileNo, smsCampaign, isNotification);
- }
+ return new SmsMessage().setExternalId(externalId).setGroup(group).setClient(client).setStaff(staff)
Review Comment:
Missing: `this.submittedOnDate = DateUtils.getBusinessLocalDate();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org