You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/08/21 22:55:38 UTC
[jira] [Created] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Colin Patrick McCabe created HDFS-3830:
------------------------------------------
Summary: test_libhdfs_threaded: use forceNewInstance
Key: HDFS-3830
URL: https://issues.apache.org/jira/browse/HDFS-3830
Project: Hadoop HDFS
Issue Type: Bug
Components: libhdfs
Affects Versions: 2.2.0-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3830:
------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0-alpha
Target Version/s: (was: 2.2.0-alpha)
Status: Resolved (was: Patch Available)
I've committed this and merged to branch-2. Thanks Colin.
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439689#comment-13439689 ]
Hudson commented on HDFS-3830:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2647 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2647/])
HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439647#comment-13439647 ]
Hudson commented on HDFS-3830:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2617 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2617/])
HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439637#comment-13439637 ]
Eli Collins commented on HDFS-3830:
-----------------------------------
Findbugs warning is HDFS-3837 and the test failure is unrelated.
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439650#comment-13439650 ]
Hudson commented on HDFS-3830:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2681 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2681/])
HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439165#comment-13439165 ]
Hadoop QA commented on HDFS-3830:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541813/HDFS-3830.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3058//console
This message is automatically generated.
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440257#comment-13440257 ]
Hudson commented on HDFS-3830:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1143 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1143/])
HDFS-3830. test_libhdfs_threaded: use forceNewInstance. Contributed by Colin Patrick McCabe (Revision 1376121)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376121
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3830:
------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
+1 pending jenkins
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439043#comment-13439043 ]
Colin Patrick McCabe commented on HDFS-3830:
--------------------------------------------
I tested the patch by running test_libhdfs_threaded. Before doing so, I added the jars from share/hadoop/hdfs and share/hadoop/common to my CLASSPATH. (I am working with the tarball layout here.)
Without this patch, the test fails intermittently. The failure mode that I saw was an exception from one thread about the FileSystem being closed (because someone closed FileSystem shared by all threads, and it doesn't reference-count.)
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Andy Isaacson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439040#comment-13439040 ]
Andy Isaacson commented on HDFS-3830:
-------------------------------------
The patch LGTM. Please comment on what testing you've done with this patch and what the impact of it is. Can you reproduce the failure locally? If so, note the frequency of failure and an example command that triggers failure.
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439036#comment-13439036 ]
Colin Patrick McCabe commented on HDFS-3830:
--------------------------------------------
by the way, this fixes a regression introduced by HDFS-2727
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HDFS-3830:
---------------------------------------
Attachment: HDFS-3830.001.patch
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.2.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HDFS-3830) test_libhdfs_threaded: use
forceNewInstance
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HDFS-3830.
-------------------------------
> test_libhdfs_threaded: use forceNewInstance
> -------------------------------------------
>
> Key: HDFS-3830
> URL: https://issues.apache.org/jira/browse/HDFS-3830
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 2.0.2-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.2-alpha
>
> Attachments: HDFS-3830.001.patch
>
>
> test_libhdfs_threaded should create new FileSystem instances with newInstance, to make sure that the test doesn't break because of interference between the different threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira