You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/01 08:40:51 UTC

[GitHub] [cloudstack] ravening commented on a change in pull request #4361: Add vpcid in usage network response

ravening commented on a change in pull request #4361:
URL: https://github.com/apache/cloudstack/pull/4361#discussion_r498078891



##########
File path: server/src/main/java/com/cloud/api/ApiDBUtils.java
##########
@@ -1568,7 +1568,7 @@ public static GuestOSCategoryVO findGuestOsCategoryById(long catId) {
     }
 
     public static VpcVO findVpcById(long vpcId) {
-        return s_vpcDao.findById(vpcId);
+        return s_vpcDao.findByIdIncludingRemoved(vpcId);

Review comment:
       Can you please tell me why this will have side effects?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org