You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/19 05:26:40 UTC

[GitHub] [arrow-rs] Jimexist commented on pull request #3119: parquet bloom filter part III: add sbbf writer, remove `bloom` default feature, add reader properties

Jimexist commented on PR #3119:
URL: https://github.com/apache/arrow-rs/pull/3119#issuecomment-1320806707

   thanks @alamb for the detailed comment. i wish to merge as is and then for subsequent steps:
   
   1. add an integration or round trip tests or maybe both
   2. adjust overall configurable parameters and then add docstring after they are settled
   
   do you think this is a good idea given that we are not releasing a new version very soon?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org