You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/07/12 11:15:21 UTC

DO NOT REPLY [Bug 49584] New: Borrowers Getting Stuck

https://issues.apache.org/bugzilla/show_bug.cgi?id=49584

           Summary: Borrowers Getting Stuck
           Product: Tomcat 7
           Version: unspecified
          Platform: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Modules: jdbc-pool
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: murphy@ben.name


The borrow connection logic seems to assume that connections will always
transition between active to idle. However, if connections move from active to
released then a borrower can get stuck in idle.poll even though there is room
in the pool for another connection to be created.

There is also an issue with connection create failing causing the pool size to
be incremented but not decremented. In the borrowConnection method the pool
size is incremented. However, if an exception occurs in the createConnection
method releaseConnection can be called with a null argument and the pool size
is not decremented.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49584] Borrowers Getting Stuck

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584

--- Comment #1 from Mark Thomas <ma...@apache.org> 2010-09-15 07:43:12 EDT ---
(In reply to comment #0)
> There is also an issue with connection create failing causing the pool size to
> be incremented but not decremented. In the borrowConnection method the pool
> size is incremented. However, if an exception occurs in the createConnection
> method releaseConnection can be called with a null argument and the pool size
> is not decremented.

I've looked at the code and I can't see a code path where con could be null. I
refactored the code to make this clearer.

I'll look at the other issue next.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49584] Borrowers Getting Stuck

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Modules: jdbc-pool          |jdbc-pool
            Product|Tomcat 7                    |Tomcat Modules

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49584] Borrowers Getting Stuck

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-09-15 09:26:22 EDT ---
Fixed in trunk and will be included in 1.0.9.0 onwards

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org