[GitHub] [pulsar] lhotari commented on a diff in pull request #17553: [ci] Enable required checks status for pulls to the master branch

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #17553:
URL: https://github.com/apache/pulsar/pull/17553#discussion_r966193532


##########
.asf.yaml:
##########
@@ -42,55 +42,27 @@ github:
     # disable rebase button:
     rebase:  false
   protected_branches:
-#    master:
-#      required_status_checks:
+    master:
+      required_status_checks:
         # strict means "Require branches to be up to date before merging".
-#        strict: false
+        strict: false
         # Contexts are the names of checks that must pass.
         # See ./github/workflows/README.md for more documentation on this list.
-#        contexts:
-#          - build
-#          - cpp-tests
-#          - Changed files check
-#          - Build and License check
-#          - CI - Unit - Brokers - Broker Group 1
-#          - CI - Unit - Brokers - Broker Group 2
-#          - CI - Unit - Brokers - Broker Group 3
-#          - CI - Unit - Brokers - Client Api
-#          - CI - Unit - Brokers - Client Impl
-#          - CI - Unit - Other
-#          - CI - Unit - Proxy
-#          - Build Pulsar java-test-image docker image
-#          - CI - Integration - Backwards Compatibility
-#          - CI - Integration - Cli
-#          - CI - Integration - Messaging
-#          - CI - Integration - Shade on Java 8
-#          - CI - Integration - Shade on Java 11
-#          - CI - Integration - Shade on Java 17
-#          - CI - Integration - Standalone
-#          - CI - Integration - Transaction
-#          - Build Pulsar docker image
-#          - CI - System - Function
-#          - CI - System - Pulsar Connectors - Process
-#          - CI - System - Pulsar Connectors - Thread
-#          - CI - System - Pulsar IO
-#          - CI - System - Schema
-#          - CI - System - Tiered FileSystem
-#          - CI - System - Tiered JCloud
-#          - CI - System - Sql
+        contexts:
+           - pulsar-ci-checks-completed

Review Comment:
   this might not be correct. It's better to run the workflow once and then use the API to ensure that the correct check name is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org