You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Taras Bobrovytsky (JIRA)" <ji...@apache.org> on 2018/01/05 23:34:00 UTC
[jira] [Resolved] (IMPALA-6355) dcheck failure for decimal asan
tests
[ https://issues.apache.org/jira/browse/IMPALA-6355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Taras Bobrovytsky resolved IMPALA-6355.
---------------------------------------
Resolution: Fixed
Assignee: Tim Armstrong (was: Taras Bobrovytsky)
Fix Version/s: Impala 2.12.0
{code}
commit 4f4912c532532bac6822a91be32d0927d505b861
Author: Tim Armstrong <ta...@cloudera.com>
Date: Wed Jan 3 10:56:58 2018 -0800
IMPALA-6355: fix overflow DCHECK in decimal mod
The bug is that ConvertToInt128(), by design, only sets 'overflow' if an
overflow occurs. This means that caller needs to initialise the overflow
variable to false, otherwise the value when overflow occurs is
undefined.
Testing:
Reprod the expr-test failure under ASAN, confirmed that it passed after
this fix.
Change-Id: Ifd7ac691155442ba7cba71dd3647208b7c1c0bf9
Reviewed-on: http://gerrit.cloudera.org:8080/8929
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
{code}
> dcheck failure for decimal asan tests
> -------------------------------------
>
> Key: IMPALA-6355
> URL: https://issues.apache.org/jira/browse/IMPALA-6355
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.12.0
> Reporter: Vuk Ercegovac
> Assignee: Tim Armstrong
> Priority: Blocker
> Labels: broken-build
> Fix For: Impala 2.12.0
>
>
> asf core asan tests have two new backend failures, likely introduced by either of these recent commits:
> https://gerrit.cloudera.org/#/c/8774/ (for IMPALA-5014)
> https://gerrit.cloudera.org/#/c/8833/ (for IMPALA-6300)
> Here are the failed tests and their stacktraces:
> [ RUN ] ExprTest.DecimalArithmeticExprs
> 22:30:05 *** Check failure stack trace: ***
> 22:30:05 @ 0x3fc73d6 google::DumpStackTraceAndExit()
> 22:30:05 @ 0x3fbddcd google::LogMessage::Fail()
> 22:30:05 @ 0x3fbf672 google::LogMessage::SendToLog()
> 22:30:05 @ 0x3fbd7a7 google::LogMessage::Flush()
> 22:30:05 @ 0x3fc0d6e google::LogMessageFatal::~LogMessageFatal()
> 22:30:05 @ 0x17ad0be impala::DecimalValue<>::Mod<>()
> 22:30:05 @ 0x179dd3c impala::DecimalOperators::Mod_DecimalVal_DecimalVal()
> 22:30:05 @ 0x16eed0d impala::ScalarFnCall::InterpretEval<>()
> 22:30:05 @ 0x16b4d81 impala::ScalarFnCall::GetDecimalVal()
> 22:30:05 @ 0x1639ea7 impala::ScalarExprEvaluator::GetValue()
> 22:30:05 @ 0x1ac4650 impala::Tuple::MaterializeExprs<>()
> 22:30:05 @ 0x2c5a86a impala::Tuple::MaterializeExprs<>()
> 22:30:05 @ 0x2c65a5a impala::UnionNode::MaterializeExprs()
> 22:30:05 @ 0x2c60540 impala::UnionNode::GetNextConst()
> 22:30:05 @ 0x2c60cba impala::UnionNode::GetNext()
> 22:30:05 @ 0x1b1c907 impala::FragmentInstanceState::ExecInternal()
> 22:30:05 @ 0x1b19cdd impala::FragmentInstanceState::Exec()
> 22:30:05 @ 0x1affe6f impala::QueryState::ExecFInstance()
> ....
> [----------] 2 tests from DecimalTest
> 22:35:55 [ RUN ] DecimalTest.Overflow
> 22:35:55 *** Check failure stack trace: ***
> 22:35:55 @ 0x3e5d816 google::DumpStackTraceAndExit()
> 22:35:55 @ 0x3e5420d google::LogMessage::Fail()
> 22:35:55 @ 0x3e55ab2 google::LogMessage::SendToLog()
> 22:35:55 @ 0x3e53be7 google::LogMessage::Flush()
> 22:35:55 @ 0x3e571ae google::LogMessageFatal::~LogMessageFatal()
> 22:35:55 @ 0x13e052e impala::DecimalValue<>::Mod<>()
> 22:35:55 @ 0x13d3a1d impala::DecimalTest_Overflow_Test::TestBody()
> ....
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)