You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2014/04/03 01:53:15 UTC

[jira] [Commented] (HADOOP-10432) Refactor SSLFactory to expose static method to determine HostnameVerifier

    [ https://issues.apache.org/jira/browse/HADOOP-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958355#comment-13958355 ] 

Aaron T. Myers commented on HADOOP-10432:
-----------------------------------------

+1, the patch looks good to me. I agree there is no need for a test case for this change.

> Refactor SSLFactory to expose static method to determine HostnameVerifier
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-10432
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10432
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-10432.patch
>
>
> The {{SSFactory.getHostnameVerifier()}} method is private and takes a configuration to fetch a hardcoded property. Having a public method to resolve a verifier based on the provided value will enable getting a verifier based on the verifier constant (DEFAULT, DEFAULT_AND_LOCALHOST, STRICT, STRICT_IE6, ALLOW_ALL).



--
This message was sent by Atlassian JIRA
(v6.2#6252)