You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/10 01:24:53 UTC
[GitHub] sjwiesman commented on a change in pull request #6814:
[FLINK-10423][rocksdb][metrics] rocksdb native metrics monitor
sjwiesman commented on a change in pull request #6814: [FLINK-10423][rocksdb][metrics] rocksdb native metrics monitor
URL: https://github.com/apache/flink/pull/6814#discussion_r223912317
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendTest.java
##########
@@ -250,7 +251,10 @@ public void testCorrectMergeOperatorSet() throws IOException {
enableIncrementalCheckpointing,
TestLocalRecoveryConfig.disabled(),
RocksDBStateBackend.PriorityQueueStateType.HEAP,
- TtlTimeProvider.DEFAULT);
+ TtlTimeProvider.DEFAULT,
+ new RocksDBNativeMetricOptions(),
+ Optional.empty()
Review comment:
It is optional because I needed a default value for overriding the previous version of `StateBackend#createKeyedStateBackend`[1]. I was not aware of `UnregisteredOperatorMetricGroup` but that would make a better fallback, will update.
[1] https://github.com/apache/flink/blob/8859febcb3cbb592d7a80d5609f9b26925dc2d45/flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java#L165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services