[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42904: [SPARK-45151][CORE][UI] Task Level Thread Dump Support

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42904:
URL: https://github.com/apache/spark/pull/42904#discussion_r1326772213


##########
core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala:
##########
@@ -52,18 +52,24 @@ private[v1] class AbstractApplicationResource extends BaseAppResource {
   @Path("executors")
   def executorList(): Seq[ExecutorSummary] = withUI(_.store.executorList(true))
 
-  @GET
-  @Path("executors/{executorId}/threads")
-  def threadDump(@PathParam("executorId") execId: String): Array[ThreadStackTrace] = withUI { ui =>
+  private def checkExecutorId(execId: String): Unit = {

Review Comment:
   If you don't mind, could you move these two new private methods, `checkExecutorId` and `checkAndGetSparkContext` at the end of this class in order to reduce the diff, please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org