You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/25 08:46:30 UTC

[GitHub] [skywalking] arugal commented on a change in pull request #3716: [test/plugin] to check agent register status

arugal commented on a change in pull request #3716: [test/plugin] to check agent register status
URL: https://github.com/apache/skywalking/pull/3716#discussion_r338947360
 
 

 ##########
 File path: test/plugin/mock-collector/src/main/java/org/apache/skywalking/plugin/test/mockcollector/Main.java
 ##########
 @@ -47,6 +55,18 @@ public static void main(String[] args) throws Exception {
         String contextPath = "/";
         ServletContextHandler servletContextHandler = new ServletContextHandler(ServletContextHandler.NO_SESSIONS);
         servletContextHandler.setContextPath(contextPath);
+        servletContextHandler.addServlet(new ServletHolder(new HttpServlet() {
+            @Override
+            protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
+                if (ValidateData.INSTANCE.getRegistryItem().getApplications().isEmpty()) {
+                    resp.setStatus(500);
 
 Review comment:
   Is there a case where there are multiple ```agent``` in one test case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services