You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by co...@apache.org on 2014/07/15 12:14:34 UTC

git commit: Fixing error in the Tomcat FederationAuthenticator

Repository: cxf-fediz
Updated Branches:
  refs/heads/master 75a8a1376 -> 489659968


Fixing error in the Tomcat FederationAuthenticator


Project: http://git-wip-us.apache.org/repos/asf/cxf-fediz/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf-fediz/commit/48965996
Tree: http://git-wip-us.apache.org/repos/asf/cxf-fediz/tree/48965996
Diff: http://git-wip-us.apache.org/repos/asf/cxf-fediz/diff/48965996

Branch: refs/heads/master
Commit: 4896599685a0a6312981e420881c0c1d731be926
Parents: 75a8a13
Author: Colm O hEigeartaigh <co...@apache.org>
Authored: Tue Jul 15 11:14:18 2014 +0100
Committer: Colm O hEigeartaigh <co...@apache.org>
Committed: Tue Jul 15 11:14:18 2014 +0100

----------------------------------------------------------------------
 .../java/org/apache/cxf/fediz/tomcat/FederationAuthenticator.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/48965996/plugins/tomcat/src/main/java/org/apache/cxf/fediz/tomcat/FederationAuthenticator.java
----------------------------------------------------------------------
diff --git a/plugins/tomcat/src/main/java/org/apache/cxf/fediz/tomcat/FederationAuthenticator.java b/plugins/tomcat/src/main/java/org/apache/cxf/fediz/tomcat/FederationAuthenticator.java
index 7a543a0..7daddd0 100644
--- a/plugins/tomcat/src/main/java/org/apache/cxf/fediz/tomcat/FederationAuthenticator.java
+++ b/plugins/tomcat/src/main/java/org/apache/cxf/fediz/tomcat/FederationAuthenticator.java
@@ -564,7 +564,7 @@ public class FederationAuthenticator extends FormAuthenticator {
             && request.getParameter("wa") == null) {
             return true;
         } else if (fedConfig.getProtocol() instanceof SAMLProtocol
-            && request.getParameter("RelayState") != null) {
+            && request.getParameter("RelayState") == null) {
             return true;
         }
         
@@ -642,7 +642,6 @@ public class FederationAuthenticator extends FormAuthenticator {
             response.sendError(
                                HttpServletResponse.SC_INTERNAL_SERVER_ERROR, "Failed to create SignInRequest.");
         }
-        
     }
 
     protected void signOutRedirectToIssuer(Request request, HttpServletResponse response, FedizProcessor processor)